Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix VS contour helper #1386

Merged
merged 2 commits into from
Feb 20, 2019
Merged

fix VS contour helper #1386

merged 2 commits into from
Feb 20, 2019

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Jan 26, 2019 •
edited
Loading

PR Description

Fix as mentioned in PR #1381
Not yet tested on VS, I can try next week on the PC of the dept.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo
Copy link
Member

dcoeurjo commented Feb 1, 2019

thx @kerautret , can you please add a Changlog entry ?

@kerautret
Copy link
Member Author

done thanks, btw I started to install a new VS config on the dept computer, not yet finished but probably finished this week.

@dcoeurjo
Copy link
Member

@kerautret is this PR complete ?

@kerautret
Copy link
Member Author

It is up to you, I have finished the VS tests but we can merge and add a new issue later, else I will be able to test perhaps tomorrow.

@dcoeurjo
Copy link
Member

Let’s merge this one. Thanks

@dcoeurjo dcoeurjo merged commit 10961d7 into DGtal-team:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BugFix waiting author feedbacks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerautret @dcoeurjo